fix(streaming): preserve Gemini thought signatures in streamed tool calls#2997
Merged
fix(streaming): preserve Gemini thought signatures in streamed tool calls#2997
Conversation
InB4DevOps
pushed a commit
to InB4DevOps/hermes-agent
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Jack <jvand@DESKTOP-JACK.localdomain>
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
Co-authored-by: Jack <jvand@DESKTOP-JACK.localdomain>
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
Co-authored-by: Jack <jvand@DESKTOP-JACK.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemini 3 thinking models include
extra_contentmetadata (containingthought_signature) on tool call responses. This signature must be replayed on subsequent API calls or Gemini rejects the request with HTTP 400.The non-streaming path already preserved
extra_content(line ~4446 in run_agent.py), but the streaming accumulator rebuilt tool calls from deltas without carrying provider-specific metadata through. This caused Gemini tool loops to fail once a streamed tool call was replayed.Fix
extra_contentfrom stream deltas during tool call accumulation (checks both direct attribute andmodel_extradict for SDK compatibility)SimpleNamespacetool callsCherry-picked from PR #2803 by @meditation-error.
Test plan
test_tool_call_extra_content_preservedverifies thought_signature survives the streaming accumulator