[no-ci] cuda_core: fix SPDX identifiers and enforce Apache-2.0 headers by rwgk · Pull Request #1897 · NVIDIA/cuda-python

rwgk · 2026-04-13T04:00:21Z

Summary

Correct the affected cuda_core/ SPDX-License-Identifier headers so they consistently use Apache-2.0.
Refactor toolshed/check_spdx.py so expected license identifiers can be enforced by path prefix, and require Apache-2.0 for files under cuda_core/.
Keep focused regression coverage in toolshed/test_check_spdx.py for the new cuda_core/ rule, path normalization, and the existing staged-file copyright autofix flow.

Validation

pre-commit run --all-files
pixi run --manifest-path "cuda_pathfinder" pytest toolshed/test_check_spdx.py -q
Output after locally and temporarily reverting commit 7738635:

$ pre-commit run --all-files
ruff check...............................................................Passed
ruff format..............................................................Passed
Check SPDX Headers.......................................................Failed
- hook id: check-spdx
- exit code: 1

INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graphdef.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/driver_cu_result_explanations.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graphdef_lifetime.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/clear_error_support.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/helpers/collection_interface_testers.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/enum_explanations_helpers.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graphdef_integration.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graph_memory_resource.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_include/utility.hpp'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graph_builder_conditional.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_utils_enum_explanations_helpers.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_utils.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_optional_dependency_imports.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_device_launch.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/runtime_cuda_error_explanations.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graphdef_errors.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_linker.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/driver_cu_result_explanations_frozen.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/helpers/graph_kernels.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/__init__.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/helpers/marks.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graphdef_mutation.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graph_builder.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_graph_update.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_cuda_utils.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/pytest.ini'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_utils/runtime_cuda_error_explanations_frozen.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/graph/test_options.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/cython/test_get_cuda_native_handle.pyx'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/cython/test_cython.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_program.py'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/cuda/core/_include/layout.hpp'
INVALID SPDX license identifier 'LicenseRef-NVIDIA-SOFTWARE-LICENSE' (expected 'Apache-2.0') in 'cuda_core/tests/test_helpers.py'

Prevent markdown files in docs/source directories....(no files to check)Skipped
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check for merge conflicts................................................Passed
check for broken symlinks................................................Passed
check toml...............................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
rst ``code`` is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst ``inline code`` next to normal text..................................Passed
mypy-pathfinder..........................................................Passed
Lint GitHub Actions workflow files.......................................Passed
cython-lint..............................................................Passed

Refactor the SPDX checker so package-specific license rules can be enforced cleanly while preserving the existing autofix flow. Keep focused regression coverage alongside the toolshed script instead of in routine package test collection. Made-with: Cursor

copy-pr-bot · 2026-04-13T04:00:27Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

rwgk · 2026-04-13T04:01:24Z

/ok to test

github-actions · 2026-04-13T04:15:21Z

Doc Preview CI
🚀 View preview at https://nvidia.github.io/cuda-python/pr-preview/pr-1897/
https://nvidia.github.io/cuda-python/pr-preview/pr-1897/cuda-core/
https://nvidia.github.io/cuda-python/pr-preview/pr-1897/cuda-bindings/
https://nvidia.github.io/cuda-python/pr-preview/pr-1897/cuda-pathfinder/
Preview will be ready when the GitHub Pages deployment is complete.

mdboom · 2026-04-13T17:11:27Z

toolshed/check_spdx.py

+    normalized_path = filepath.replace("\\", "/")
+    while normalized_path.startswith("./"):
+        normalized_path = normalized_path[2:]
+    return normalized_path


How does this differ from / why doesn't it use os.path.normpath?

Cursor found a better implementation. I asked it to add a full explanation. Please take another look:

commit eef3902

mdboom · 2026-04-13T17:14:16Z

toolshed/test_check_spdx.py

+    assert "OUTDATED copyright '2024' (expected '2026')" in capsys.readouterr().out
+    assert "Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved." in path.read_text(
+        encoding="ascii"
+    )


I think we should add this to CI or just remove it. It's only going to bitrot if it sits here.

Done: commit 36a4914

… CI, but it will bit-rot if untested).

Use a standard-library path normalizer so repo-prefix checks treat Windows-style paths consistently on any host. Document why os.path.normpath is not suitable for this forward-slash prefix comparison. Made-with: Cursor

rwgk · 2026-04-13T19:12:01Z

I added [no-ci] to the PR title to not waste our CI resources: we had one successful run already:

https://github.com/NVIDIA/cuda-python/actions/runs/24325040151?pr=1897

I'll push updates to toolshed/check_spdx.py, they will still be exercised with the pre-commit.ci - pr workflow.

rwgk added 2 commits April 12, 2026 20:12

Systematically correct SPDX-License-Identifier: Apache-2.0

7738635

rwgk added this to the cuda.core v1.0.0 milestone Apr 13, 2026

rwgk self-assigned this Apr 13, 2026

rwgk added bug Something isn't working P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Apr 13, 2026

rwgk marked this pull request as ready for review April 13, 2026 16:00

rwgk requested a review from mdboom April 13, 2026 16:58

mdboom requested changes Apr 13, 2026

View reviewed changes

rwgk added 3 commits April 13, 2026 11:56

Merge branch 'main' into cuda_core_license_fixes

40ebb43

Remove toolshed/test_check_spdx.py (too much trouble adding it to the…

36a4914

… CI, but it will bit-rot if untested).

toolshed: normalize SPDX paths with PureWindowsPath

eef3902

Use a standard-library path normalizer so repo-prefix checks treat Windows-style paths consistently on any host. Document why os.path.normpath is not suitable for this forward-slash prefix comparison. Made-with: Cursor

rwgk changed the title ~~cuda_core: fix SPDX identifiers and enforce Apache-2.0 headers~~ [no-ci] cuda_core: fix SPDX identifiers and enforce Apache-2.0 headers Apr 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[no-ci] cuda_core: fix SPDX identifiers and enforce Apache-2.0 headers#1897

[no-ci] cuda_core: fix SPDX identifiers and enforce Apache-2.0 headers#1897
rwgk wants to merge 5 commits intoNVIDIA:mainfrom
rwgk:cuda_core_license_fixes

rwgk commented Apr 13, 2026

Uh oh!

copy-pr-bot bot commented Apr 13, 2026

Uh oh!

rwgk commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

mdboom Apr 13, 2026

Uh oh!

rwgk Apr 13, 2026

Uh oh!

mdboom Apr 13, 2026

Uh oh!

rwgk Apr 13, 2026

Uh oh!

rwgk commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rwgk commented Apr 13, 2026

Summary

Validation

Uh oh!

copy-pr-bot bot commented Apr 13, 2026

Uh oh!

rwgk commented Apr 13, 2026

Uh oh!

github-actions bot commented Apr 13, 2026

Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

mdboom Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

mdboom Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants