[WIP] Issue #33 — Add github actions#34
Merged
lefticus merged 1 commit intoChaiScript:masterfrom Apr 17, 2026
Merged
Conversation
Adds a CI workflow modeled on ChaiScript/ChaiScript's pattern: build and test across Linux (GCC), macOS (AppleClang), and Windows (MSVC) in both Debug and Release, plus ASAN+UBSAN sanitizer jobs on Linux and macOS. The workflow reuses the project's existing CMake options (ENABLE_ADDRESS_SANITIZER, ENABLE_UNDEFINED_SANITIZER), so no build-system changes are required. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
leftibot
added a commit
to leftibot/ChaiScript_Extras
that referenced
this pull request
Apr 17, 2026
The CI introduced in ChaiScript#34 surfaced two failures rooted in the outdated CMakeLists.txt fetched as part of ChaiScript 6.1.0: 1. macOS runners ship CMake 4.x, which removes compatibility with cmake_minimum_required(VERSION < 3.5). The fetched subproject still declares VERSION 2.8 and configure aborts. Setting CMAKE_POLICY_VERSION_MINIMUM to 3.5 before add_subdirectory forces an acceptable floor for the transitive project. 2. Windows MSVC builds fail compiling ChaiScript's own src/main.cpp (the `chai` REPL) - a missing <chrono> include in upstream 6.1.0. The REPL target is unconditionally declared by the subproject, so adding EXCLUDE_FROM_ALL on add_subdirectory keeps it out of the default build. chaiscript_extras only needs ChaiScript's headers, so nothing else changes. Also modernized: bump cmake_minimum_required to 3.16, drop the now-unused BUILD_MODULES toggle, and explicitly opt into CMP0169 OLD so the deprecated FetchContent_Populate call is kept quiet on CMake 3.30+. Note: this PR does not address the unrelated ASAN/UBSAN heap-use-after-free surfaced by string_methods_test - that is a runtime bug in the extras+ChaiScript 6.1.0 interaction and will be tracked separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated attempt by @leftibot. Opening as draft — verification failed.
Reason: no test files were detected in the diff
What changed
Files
Will close #33 once finalized.
Triggered by @lefticus.