Notification marked as done still being returned in the notifications endpoint

[brpaz]

Select Topic Area

Bug

Body

Hello.

I am building a script to "mark as done" old notifications, and it´s working fine as the notifications disapeared from my Inbox on GitHub UI, but when using API agian to fetch the list of notifications, those "deleted" ones are being returned again.

I can reproduce this using curl:

curl -I -L -X DELETE -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $GITHUB_TOKEN" -H "X-GitHub-Api-Version: 2022-11-28" https://github.com/api/notifications/threads/13972906989

this returns 204

when I do:

curl -L -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $GITHUB_TOKEN" -H "X-GitHub-Api-Version: 2022-11-28" "https://github.com/api/notifications?all=true&before=2025-01-01" | jq

The notification is still being recored:

 {
    "id": "13972906989",
    "unread": false,
    "reason": "subscribed",
    "updated_at": "2024-12-22T14:30:02Z",
    "last_read_at": null,
    "subject": {
      "title": "39.81.0",
      "url": "https://github.com/api/repos/renovatebot/renovate/releases/192016824",
      "latest_comment_url": "https://github.com/api/repos/renovatebot/renovate/releases/192016824",
      "type": "Release"
    },
}

could be because the all parameter. Documentation only says when passing the all parameter, it returns read notifications. does not mention done.

If that´s the case is there any way I can know if the notification is done? I want to still be able, to mark read notifications as done.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐